Fix ttl for the SQLiteStorage #119
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HassanRady
commented
Nov 29, 2023
HassanRady
commented
- Replace bigger than sign with smaller in sync and async in _remove_expired_caches for sqlite.
- Add two test cases for sync and async to test sqlite cache lifecycle.
added 2 commits
November 29, 2023 13:45
…e' into Issue-118-fix-sqlite-expire-cahce # Conflicts: # tests/_async/test_storages.py # tests/_sync/test_storages.py
|
You can write only the async code and then run Can we also have a changelog? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1769 1775 +6
=========================================
+ Hits 1769 1775 +6 ☔ View full report in Codecov by Sentry. |
|
I have a little bit simplified the tests, so we don't have a special test for sqlite storage. Thanks for this pull request 🙏 I will schedule a release for tomorrow 🎉 |
karpetrosyan
approved these changes
Nov 29, 2023
This was referenced Nov 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.